Adding warning message for vsmdi file #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smadala
reviewed
Dec 5, 2017
| @@ -1011,6 +1011,21 @@ public void IsLegacyScenarioReturnsTrueWhenTestSettingsFileIsGiven() | |||
| Assert.IsTrue(MSTestSettings.IsLegacyScenario(this.mockMessageLogger.Object)); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void IsLegacyScenarioReturnsTrueWhenVsmdiFileIsGiven() | |||
There was a problem hiding this comment.
This test is not required because we don't check for file extension and it is covered in IsLegacyScenarioReturnsTrueWhenTestSettingsFileIsGiven.
Consider adding test to check warning message warning message.
| @@ -285,7 +285,7 @@ | |||
| <value>The test method {0}.{1} has multiple attributes derived from ExpectedExceptionBaseAttribute defined on it. Only one such attribute is allowed.</value> | |||
| </data> | |||
| <data name="LegacyScenariosNotSupportedWarning" xml:space="preserve"> | |||
| <value>Warning : A testsettings file or a runsettings with a ForcedLegacyMode set to true is not supported with the MSTest V2 Adapter.</value> | |||
| <value>Warning : A vsmdi file, testsettings file or a runsettings file with a ForcedLegacyMode set to true is not supported with the MSTest V2 Adapter.</value> | |||
There was a problem hiding this comment.
How about change it to "A testsettings file, a runsettings file with a ForcedLegacyMode set to true or a vsmdi file is not supported with the MSTest V2 Adapter." ? As vsmdi is less popular. /cc @pvlakshm
singhsarab
pushed a commit
to singhsarab/testfx
that referenced
this pull request
Apr 8, 2019
* Fixed versioning miss match of Testplatform.vsix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.