-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test execution bugs in specific TFMs addressed. #1071
Conversation
I'm concerned about false positives/negatives, as using WinUI is not equivalent to executing in a packaged app. |
Currently we only support packaged WinUI applications. I am experimenting with non packaged ones. I might amend this PR to include support this weekend. |
Sounds good. Also note that in addition to packaged non-WinUI apps, you can have an unpackaged WinUI app. |
Support for unpackaged-apps are also here. See PR description for details. |
src/Adapter/PlatformServices.WinUI/Services/WinUIFileOperations.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.WinUI/Services/WinUIFileOperations.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.WinUI/Services/WinUIFileOperations.cs
Outdated
Show resolved
Hide resolved
src/Adapter/PlatformServices.WinUI/Services/WinUIFileOperations.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some integration test (probably the test case we used for manual testing).
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
src/TestFramework/MSTest.Core/Attributes/TestMethod/TestMethodAttribute.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Attributes/TestMethod/TestMethodAttribute.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nit comments - feel free to ignore them.
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
eb53fac
to
6fe4b68
Compare
looking over the code it seems it is more about testing packaged apps rather than testing WinUI, or am I missing something here? |
It also supports unpackaged apps, you can find a sample here. I'll also update the documentation. |
Fixed test execution under net5+ TFMs.
Fixed UWP test execution.
Fixed MSTest V2 tests won't run when targeting net5.0-windows10.0.19041 #991
Fixed Tests are ignored for OS version-specific TFMs #982
Fixed MSTest.TestFramework 2.2.4: 'TestContext' does not contain a definition for 'TestRunDirectory' in net5.0-windows10.0.19041 project #851
Fixed .NET 5 TFM Support? #750
Remarks
From now on, WinUI packaged tests are required to specify
UseWinUI
property in*.csproj
and set it true.Packaged apps
This blog post form @azchohfi is still current, just make sure you're using WinUI 1.0.0 or later.
Also,
UseWinUI
property needs to be specified.Unpackaged apps
.csproj
file and add.csproj
file make sure you're referencing1.0.1+
version ofMicrosoft.WindowsAppSDK
package.Building this branch to test
./artifacts/Debug/MSTestPackages/
to your nuget.config file.