AssemblyCleanup exception hides test failure

[greuelpirat]

An exception in AssemblyCleanup hides test exception

Steps To Reproduce

Run this:

[TestClass]
public sealed class Test1
{
    [TestMethod]
    public void TestMethod1()
    {
        Assert.Fail("I want to see this");
    }

    [AssemblyCleanup]
    public static void Shutdown()
    {
        throw new Exception("... but I only see this");
    }
}

Expected behavior

"I want to see this" should be seen in the output

Actual behavior

but this is the only output:

   ...\MSTestProject1.dll : error TESTERROR: 
      TestMethod1 (140ms): Fehlermeldung: Fehler bei der Methode "Test1.Shutdown" für die Assemblybereinigung. Fehlermeldung: System.Exception: ... but I only see this. "StackTrace":     bei MSTestPro
      ject1.Test1.Shutdown() in ...\MSTestProject1\Test1.cs:Zeile 15.
      
      Stapelverfolgung:
         bei Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.TestAssemblyInfo.ExecuteAssemblyCleanup() in /_/src/Adapter/MSTest.TestAdapter/Execution/TestAssemblyInfo.cs:Zeile 316.
         bei Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner.RunAssemblyCleanupIfNeeded(ITestContext testContext, ClassCleanupManager classCleanupManager, TypeCache typ

[greuelpirat]

ui, sorry, wrong project. I created an issue for MSTest here

i close this

[Youssef1313]

This is the right repo.

[Youssef1313]

Which version of MSTest are you using? Did you try the latest version?

[Youssef1313]

This is likely already fixed by #5505 (MSTest 3.9.0 and later - it's recommended to be on the latest MSTest 4.x)

[greuelpirat]

Which version of MSTest are you using? Did you try the latest version?

In the reproducing project I was indeed not on the latest version. But in our real project, I am indeed on a 4.x where it behaves differently but still not as expected:

MSTestProject1.zip

PS ...\TestProject2> dotnet test .\MSTestProject1\
Wiederherstellung abgeschlossen (0,2s)
  MSTestProject1 Erfolgreich (0,2s) → MSTestProject1\bin\Debug\net48\MSTestProject1.dll
  MSTestProject1 Test fehlerhaft mit 1 Fehler(n) (1,3s)
    C:\Program Files\dotnet\sdk\9.0.310\Microsoft.TestPlatform.targets(48,5): error TESTERROR: TestMethod1 (95ms): Fehlermeldung: Mindestens ein Fehler ist aufgetreten.

Testzusammenfassung: insgesamt: 1; fehlgeschlagen: 1; erfolgreich: 0; übersprungen: 0; Dauer: 1,3 Sek.
Erstellen von fehlerhaft mit 1 Fehler(n) in 2,1s

and in Rider I just see this:

I opened an issue, but they wrote I should pass this to MSTest

Maybe both exceptions are correctly wrapped within an AggregateException, but the inner exceptions are not visible?