Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredevops_build_folder_permissions - Avoid potential null pointer #714

Merged
merged 1 commit into from
Feb 16, 2023
Merged

azuredevops_build_folder_permissions - Avoid potential null pointer #714

merged 1 commit into from
Feb 16, 2023

Conversation

xuzhang3
Copy link
Collaborator

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Checks for the existence of the folder, and returns error message if the folder not found.

Issue Number: #710

=== RUN   TestAccBuildDefinitionPermissions_SetPermissions
=== PAUSE TestAccBuildDefinitionPermissions_SetPermissions
=== RUN   TestAccBuildDefinitionPermissions_UpdatePermissions
=== PAUSE TestAccBuildDefinitionPermissions_UpdatePermissions
=== CONT  TestAccBuildDefinitionPermissions_SetPermissions
=== CONT  TestAccBuildDefinitionPermissions_UpdatePermissions
--- PASS: TestAccBuildDefinitionPermissions_SetPermissions (54.82s)
--- PASS: TestAccBuildDefinitionPermissions_UpdatePermissions (74.52s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        81.129s

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 merged commit a83701b into microsoft:main Feb 16, 2023
@xuzhang3 xuzhang3 deleted the f/path_permission branch October 23, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant