-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'auto_update' #690
Conversation
@microsoft-github-policy-service agree company="Vodafone" |
…p[string]interface {}' messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulkirkwood A few change request others look to me.
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_artifactory.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we call the update after the create if the auto_update
set to false? So that user can initially set it to true or false.
Example code:
func resourceAzureAgentPoolCreate(d *schema.ResourceData, m interface{}) error {
clients := m.(*client.AggregatedClient)
agentPool, err := expandAgentPool(d, true)
if err != nil {
return fmt.Errorf("Error converting terraform data model to AzDO agentPool reference: %+v", err)
}
createdAgentPool, err := createAzureAgentPool(clients, agentPool)
if err != nil {
return fmt.Errorf("Error creating agent pool in Azure DevOps: %+v", err)
}
if agentPool.AutoUpdate != nil && !*agentPool.AutoUpdate {
agentPool.Id = createdAgentPool.Id
createdAgentPool, err = azureAgentPoolUpdate(clients, agentPool)
if err != nil {
return fmt.Errorf("Error updating agent pool in Azure DevOps: %+v", err)
}
}
flattenAzureAgentPool(d, createdAgentPool)
return resourceAzureAgentPoolRead(d, m)
}
|
All Submissions:
What about the current behavior has changed?
Added behaviour to allow the setting of the 'auto_update' attribute within a 'azuredevops_agent_pool' resource.
Issue Number: #688
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?