Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredevops_serviceendpoint_sonarcloud #658

Merged
merged 6 commits into from
Nov 2, 2022
Merged

azuredevops_serviceendpoint_sonarcloud #658

merged 6 commits into from
Nov 2, 2022

Conversation

martenvd
Copy link
Contributor

@martenvd martenvd commented Oct 26, 2022

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

Explaination of changes

This PR should resolve issue #657, for the azuredevops_serviceendpoint_sonarcloud resource can create all the endpoints for all my projects I would like to enable the SonarCloud endpoint for. This would make my life a lot easier, as well as my fellow engineers because we can add these endpoints to our existing code instead of creating completely new code or calling the API from scratch.

What about the current behavior has changed?

Issue Number: #657

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

@xuzhang3
Copy link
Collaborator

@martenvd got error when run Acctests:

Error: Error creating service endpoint in Azure DevOps: Unable to find service connection type 'sonarcloud' using authentication scheme 'UsernamePassword'.

@martenvd
Copy link
Contributor Author

Added the requested changes.

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Nov 1, 2022

=== RUN   TestAccServiceEndpointSonarCloud_basic
=== PAUSE TestAccServiceEndpointSonarCloud_basic
=== RUN   TestAccServiceEndpointSonarCloud_complete
=== PAUSE TestAccServiceEndpointSonarCloud_complete
=== RUN   TestAccServiceEndpointSonarCloud_update
=== PAUSE TestAccServiceEndpointSonarCloud_update
=== RUN   TestAccServiceEndpointSonarCloud_RequiresImportErrorStep
=== PAUSE TestAccServiceEndpointSonarCloud_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointSonarCloud_basic
=== CONT  TestAccServiceEndpointSonarCloud_update
=== CONT  TestAccServiceEndpointSonarCloud_RequiresImportErrorStep
=== CONT  TestAccServiceEndpointSonarCloud_complete
--- PASS: TestAccServiceEndpointSonarCloud_complete (64.13s)
--- PASS: TestAccServiceEndpointSonarCloud_basic (64.22s)
--- PASS: TestAccServiceEndpointSonarCloud_RequiresImportErrorStep (66.31s)
--- PASS: TestAccServiceEndpointSonarCloud_update (89.46s)
PASS

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Nov 2, 2022

@martenvd LGTM

@xuzhang3 xuzhang3 merged commit b5cc43a into microsoft:main Nov 2, 2022
@martenvd martenvd deleted the sonarcloud-serviceendpoint branch November 2, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants