-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azuredevops_serviceendpoint_sonarcloud #658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@martenvd got error when run Acctests:
|
xuzhang3
requested changes
Oct 31, 2022
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_sonarcloud.go
Outdated
Show resolved
Hide resolved
Added the requested changes. |
xuzhang3
previously approved these changes
Nov 1, 2022
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_sonarcloud.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_sonarcloud.go
Outdated
Show resolved
Hide resolved
xuzhang3
reviewed
Nov 1, 2022
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_sonarcloud.go
Outdated
Show resolved
Hide resolved
|
@martenvd LGTM |
xuzhang3
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Explaination of changes
This PR should resolve issue #657, for the
azuredevops_serviceendpoint_sonarcloud
resource can create all the endpoints for all my projects I would like to enable the SonarCloud endpoint for. This would make my life a lot easier, as well as my fellow engineers because we can add these endpoints to our existing code instead of creating completely new code or calling the API from scratch.What about the current behavior has changed?
Issue Number: #657
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?