Create datasource azuredevops_serviceendpoint_github, add common func…

[a30004053]

…tions to create datasource schemas, fix documentation

All Submissions:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My code follows the code style of this project.
• I ran lint checks locally prior to submission.
• Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

This PR adds a new data source azuredevops_serviceendpoint_github which returns details of a GitHub service endpoint defined by an id or a unique service_endpoint_name

Issue Number: #608

Does this introduce a change to go.mod, go.sum or vendor/?

• Yes
• No

Does this introduce a breaking change?

• Yes
• No

Any relevant logs, error output, etc?

https://pst.klgrth.io/paste/4t6et

Other information

Additional functions are added to azuredevops/internal/service/serviceendpoint/commons.go to support common dataSource schemas and serviceendpoint lookup functions

Modifications were made to azuredevops_serviceendpoint_azurerm datasource as a result of the aforementioned additions to commons.go

[a30004053]

TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource

TF_ACC=1 go test -tags "all" $(go list ./azuredevops/internal/acceptancetests |grep -v 'vendor') -v -run=TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource -timeout 120m
=== RUN   TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource
=== PAUSE TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource
=== CONT  TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource
--- PASS: TestAccServiceEndpointGitHub_with_serviceEndpointName_DataSource (61.09s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        61.205s

TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource

TF_ACC=1 go test -tags "all" $(go list ./azuredevops/internal/acceptancetests |grep -v 'vendor') -v -run=TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource -timeout 120m
=== RUN   TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource
=== PAUSE TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource
=== CONT  TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource
--- PASS: TestAccServiceEndpointGitHub_with_serviceEndpointID_DataSource (51.51s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        51.625s

[a30004053]

Hello @xuzhang3,

Hope you are well.
When you get a chance can you please review this PR?

Cheers!

[xuzhang3]

@a30004053 thanks for your contribute. A few change requested, others look good to me.

[a30004053]

Hello @xuzhang3,

If it all looks okay from your end, can this PR be merged?

Thanks in advance!

[xuzhang3]

@a30004053 LGTM