Add initial support for bracketed paste mode#8909
Add initial support for bracketed paste mode#8909skyline75489 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
|
Dustin mentioned his effort to bring "bracketed paste mode" into conhost (#7508 (comment)). I don't know enough about conhost or conpty so I limited my implementation to WT. This is an early implementation and will conflict with #8875 , so I marked this as a draft. |
|
This is pretty straightforward. I'm wondering if this has any side effects that I don't know about. If the overall direction is correct, I'll polish the PR later the mark it as ready for review. |
|
I don't think this is as straightforward as one might think. Are you filtering out an explicit end sequence from the source sequence before pasting? This is a common bypass attempted in malicious scenarios (update: just checked - you're not) Here are some eye opening dirty tricks to digest if you haven't seen them before: https://thejh.net/misc/website-terminal-copy-paste |
zadjii-msft
left a comment
There was a problem hiding this comment.
I don't see what's wrong with this. Thanks!
|
@msftbot make sure @DHowett signs off on this |
|
Hello @zadjii-msft! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
Closed in favor of #9034 |
Summary of the Pull Request
This adds "bracketed paste mode" to the Windows Terminal.
References
Supersedes #7508
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed