Fix multi-line paste warning to detect carriage return#8608
Closed
Don-Vito wants to merge 2 commits intomicrosoft:mainfrom
Closed
Fix multi-line paste warning to detect carriage return#8608Don-Vito wants to merge 2 commits intomicrosoft:mainfrom
Don-Vito wants to merge 2 commits intomicrosoft:mainfrom
Conversation
ghost
added
Area-UserInterface
zadjii-msft
approved these changes
Dec 18, 2020
Member
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
I mean, this seems reasonable, right?
Contributor
Author
|
@zadjii-msft - this one is on hold, as the team has ideas for more holistic solution, doing the detection and filtering in the same pass |
Member
|
Closing in favor of #8634. I didn't realize we couldn't do it in a single pass because of the layering between the two components--I'd rather the filtering happen in Control (so anybody can get filtering) and the detection happen in App. Oh well. Thanks again, and thanks for the feedback on #8634. Sorry for putting you on hold 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Validation Steps Performed