Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --title to the wt.exe commandline args #6296

Merged
1 commit merged into from
Jun 2, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

Adds support for setting the terminal title with the commandline argument --title <title>.

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • I wasn't sure how we felt about -t being the short version of this argument, so I left it out. If we're cool with that, adding it wouldn't be hard.

Validation Steps Performed

image

@ghost ghost added Area-Commandline wt.exe's commandline arguments Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jun 1, 2020
@miniksa
Copy link
Member

miniksa commented Jun 1, 2020

  • I wasn't sure how we felt about -t being the short version of this argument, so I left it out. If we're cool with that, adding it wouldn't be hard.

I feel like -t could mean too many things. Tab, title.... I'm sure there are more. But I'm not the one with the pulse of the command-line args as much as @DHowett is.

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to me.

@miniksa miniksa added the Needs-Second It's a PR that needs another sign-off label Jun 2, 2020
@ghost ghost requested review from carlos-zamora and leonMSFT June 2, 2020 15:33
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was easy

@DHowett
Copy link
Member

DHowett commented Jun 2, 2020

We can think about -t later. I'm not sure how i feel about it.

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 2, 2020
@ghost
Copy link

ghost commented Jun 2, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 88db0e6 into master Jun 2, 2020
@ghost ghost deleted the dev/migrie/f/6183--title branch June 2, 2020 18:52
@ghost
Copy link

ghost commented Jun 18, 2020

🎉Windows Terminal Preview v1.1.1671.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 18, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set tabTitle in commandline
4 participants