-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix localizability issues in Windows Terminal #5339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty slick
f2030b0
to
335a12a
Compare
* Lock some strings, or parts of strings, that should not be localized. * Switch to positional format parameters * Remove the forced newlines in the warning resources; insert them at runtime Fixes MSFT:25936156.
2c33316
to
b80839b
Compare
@msftbot merge this in 2 minutes |
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Loc issues are given to us through the internal bug tracker.
runtime
Fixes MSFT:25936156.