Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process actions sync. on startup; don't dupe nonexistent profile #5090

Merged
merged 39 commits into from
Mar 26, 2020

Commits on Jan 31, 2020

  1. Configuration menu
    Copy the full SHA
    a8bd503 View commit details
    Browse the repository at this point in the history
  2. Try writing tests

      You need to initialize a TerminalPage weirdly in the test, including _not_ checking App.Logic(), since the App doesn't have a Logic()
    zadjii-msft committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    648373d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    029b676 View commit details
    Browse the repository at this point in the history
  4. Fix the tests o__o

    zadjii-msft committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    0a6f72c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9849fe9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    963a830 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. Merge branch 'master' into dev/migrie/b/2455-with-new-tests

    # Conflicts:
    #	src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp
    #	src/cascadia/TerminalApp/TerminalPage.cpp
    zadjii-msft committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    8ed39cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82ad8bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eafe9c8 View commit details
    Browse the repository at this point in the history
  4. Try to clone the settings directly from the control

      Okay this is harder, but maybe not impossible, but probably impossible in v1.
    
      The Profile knows how to build the connection settings, and the
      ControlSettings, etc. However, when the settings reloads like in this bug,
      we'll remove all the old profiles, and build a new list.
    
      If we wanted the case 1 behavior, we could wait until the Profile is a winrt
      object, then have each Pane hold a strong ref to the Profile that it's
      hosting. Then it would be trivial to be able to duplicate the settings from
      it. I believe that work is tracked in #3998.
    
      How palatable is doing case 3 now (to fix the crash), then filing a follow up
      to do case 1 once #3998 is done?
    zadjii-msft committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    908fd74 View commit details
    Browse the repository at this point in the history
  5. Revert "I _think_ this will pull the settings from the control, but I…

    … haven't tested yet"
    
    This reverts commit 82ad8bb.
    zadjii-msft committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    4561b9a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9eaee52 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e952c0d View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Configuration menu
    Copy the full SHA
    07050b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bb6803 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    499b003 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95bb854 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a058181 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    998318a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Configuration menu
    Copy the full SHA
    f3948d8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    332a577 View commit details
    Browse the repository at this point in the history
  3. okay this fixes this test

    zadjii-msft committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    1dffef4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e2e45a9 View commit details
    Browse the repository at this point in the history
  5. cleanup the test

    zadjii-msft committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    808868f View commit details
    Browse the repository at this point in the history
  6. This is a ton of colde cleanup ; wtd split-pane is broken, doesn't …

    …create the first tab :O
    zadjii-msft committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    6208f43 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7e0685f View commit details
    Browse the repository at this point in the history
  8. this fixes just a bare wt split-pane; `wt; ; ; focus-tab -t 1; spli…

    …t-pane` doesn't seem to work anymore
    zadjii-msft committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    09ab62a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ce2b948 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Configuration menu
    Copy the full SHA
    4306389 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b3b517 View commit details
    Browse the repository at this point in the history
  3. some test code cleanup

    zadjii-msft committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    e80ee31 View commit details
    Browse the repository at this point in the history
  4. code cleanup for review

    zadjii-msft committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    9cd77e8 View commit details
    Browse the repository at this point in the history
  5. finalize code cleanup

    zadjii-msft committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    7507f9f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    60b2a49 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Configuration menu
    Copy the full SHA
    393492b View commit details
    Browse the repository at this point in the history
  2. wacky--;

    zadjii-msft committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    a1c7f7e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Configuration menu
    Copy the full SHA
    1a15db3 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    34391c7 View commit details
    Browse the repository at this point in the history
  3. spelling

    DHowett committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c3facb5 View commit details
    Browse the repository at this point in the history