Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WT_SESSION to WSLENV so it propagates into WSL #4157

Merged
2 commits merged into from
Jan 9, 2020
Merged

Add WT_SESSION to WSLENV so it propagates into WSL #4157

2 commits merged into from
Jan 9, 2020

Conversation

DHowett-MSFT
Copy link
Contributor

This makes sure that things running inside WSL can see WT_SESSION.

Closes #3948.

@DHowett-MSFT
Copy link
Contributor Author

I moved the environment block load to before we set the variables because we need to read WSLENV. I had to replace WT_SESSION with insert_or_assign because emplace does not overwrite.

@zadjii-msft zadjii-msft added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal. labels Jan 9, 2020
@ghost ghost requested review from miniksa, carlos-zamora and leonMSFT January 9, 2020 14:13
@ghost
Copy link

ghost commented Jan 9, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 988f0a6 into master Jan 9, 2020
@ghost ghost deleted the dev/duhowett/wsl2 branch January 9, 2020 19:23
@ghost
Copy link

ghost commented Jan 14, 2020

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jan 14, 2020
Closed
@abarani abarani mentioned this pull request Jul 30, 2020
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WT_SESSION doesn’t appear in WSL
4 participants
@DHowett-MSFT @miniksa @zadjii-msft @DHowett