Add tab width modes: equal and titleLength #3876

cinnamon-msft · 2019-12-06T23:16:14Z

Summary of the Pull Request

Created new global setting "tabWidthMode"
Will accept "equal" or "titleLength"
Equal: Similar to browser experience where all tabs are equal width
TitleLength: Original implementation where width will fit whole tab title

Changed default width behavior to Equal

Refs #597

carlos-zamora

Not sure about the default yet but the other issue I had is not really worth blocking over.

doc/cascadia/SettingsSchema.md

Co-Authored-By: Carlos Zamora <carlos.zamora@microsoft.com>

DHowett-MSFT

I think this needs a mini-spec, actually.

Couple thoughts:

this isn't a width, it is a width mode
should we ditch the names equal and sizeToContent? We inherited them from the tab control, but are they right for our users?
should we eventually support a multi-state width syntax?
- $min - $max, so I could specify 10-300
- 300 would be shorthand for 300-300 (fixed width)
- 300-auto would be min=300, max = undefined
- auto would be shorthand for auto-auto
- the default would be auto (the same behavior as today)

(I'm not asking for a spec because I want these idea to win; I'm asking because if I'm thinking them, others may be too, and that warrants a discussion 😄)
*

DHowett-MSFT · 2019-12-06T23:41:43Z

should it be profile-specific?

DHowett-MSFT · 2019-12-06T23:42:01Z

should it live at the root object? what if we do want to make mode and min/max separate things?

rkeithhill · 2019-12-07T00:32:32Z

RE equal vs size-to-content, what I'd like to see isn't necessarily either. Ideally, what I want is a tab system that obeys this one simple precept: all tabs are always visible with no need to scroll to see tabs. Well, except when perhaps the tabs get ridiculously narrow e.g.:

But ^ is fairly corner case.

Given this particularly precept, when there are a small number of tabs, you could size to content but when those combined tab widths exceed the width of the tab area, then you switch to fixed-width such that all tabs are guaranteed to be visible.

zadjii-msft

I think I agree with @DHowett-MSFT, I kinda expected a mini-spec laying out the possible states that people would want for this.

I kinda expected that there'd be two settings here: tabMinWidth and tabMaxWidth.

tabMinWidth = tabMaxWidth = null (or undefined): the behavior we have now, size to content
tabMinWidth = tabMaxWidth = 200 (or whatever): the "equal" behavior from this PR
tabMinWidth = null, tabMaxWidth = 200: tabs can be arbitrarily small, but capped at 200px
etc.

The only problem I foresaw with that design was the future hypothetical "split" sizing (where tabs take all the space available to them) wasn't really represent-able. I was hoping we'd be able to come up with a combination of settings that would enable all these scenarios.

Plus, now there's @rkeithhill's suggestion, to keep making tabs smaller (to the theoretical tabMinWidth). Not sure how that's functionally possible with the current TabView (probably isn't). We'd probably want to follow up with them to get support for such a mode.
In the meantime, we'll want to make sure that there's a future-proof design that takes that into account.

The implementation looks fine by me, I kinda think this does need a spec, tbh.

zadjii-msft · 2019-12-09T15:05:34Z

doc/cascadia/SettingsSchema.md

@@ -13,6 +13,7 @@ Properties listed below affect the entire window, regardless of the profile sett
 | `requestedTheme` | _Required_ | String | `system` | Sets the theme of the application. Possible values: `"light"`, `"dark"`, `"system"` |
 | `showTerminalTitleInTitlebar` | _Required_ | Boolean | `true` | When set to `true`, titlebar displays the title of the selected tab. When set to `false`, titlebar displays "Windows Terminal". |
 | `showTabsInTitlebar` | Optional | Boolean | `true` | When set to `true`, the tabs are moved into the titlebar and the titlebar disappears. When set to `false`, the titlebar sits above the tabs. |
+| `tabWidth` | Optional | String | `equal` | Sets the width of the tabs. Possible values: `"equal"`, `"sizeToContent"` |


This doc suggests sizeToContent, though the rest of the pr says sizetocontent. I'm pretty sure we should go with the camelCase one

zadjii-msft · 2019-12-09T15:22:09Z

* should it live at the root object? what if we _do_ want to make mode and min/max separate things?

I think I'm okay with this being in the root (globals) for now. This is an "application" settings, so it should live with the other application settings. In the future, we might want to consider these properties as being a part of the
theme, but I don't think we should hold up putting them in the root for now over that. We can always do a similar colorscheme/foreground (where the property from the profile overrides that from the colorscheme) thing with this once themes exist.

vadimkantorov · 2019-12-13T05:03:18Z

So many people raised issues, I hope equal mode is chosen as the default one

ghost · 2019-12-20T06:00:18Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

zadjii-msft · 2019-12-20T13:28:31Z

shh msftbot, it's the holidays. Take a break.

ghost · 2019-12-27T14:00:25Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

rkeithhill · 2019-12-28T07:02:13Z

msftbot needs to be made aware of extended holiday breaks. :-)

miniksa · 2019-12-30T23:02:24Z

This comment represents me seeing this PR but choosing to not review it because there's already 3 cooks in this kitchen (despite the holiday). It serves to remind me of this decision in the future.

cinnamon-msft · 2020-01-03T19:13:44Z

Spec can be found here: #4104

Chatted o*line with Kayla

zadjii-msft

Sure, there's a spec for the min/max size bits now, so I'm happy with this. I'll unblock it :)

DHowett-MSFT

please add this to defaults.json

ghost · 2020-01-14T17:16:16Z

🎉Windows Terminal Preview v0.8.10091.0 has been released which incorporates this pull request.:tada:

Handy links:

This is the spec for #597 I am proposing the `tabWidthMode` feature be added first, then `tabWidthMin` and `tabWidthMax` be added in a later release. PR: #3876

tab sizing functionality

9c9f233

cinnamon-msft requested a review from a team December 6, 2019 23:16

cinnamon-msft changed the title ~~Added tab sizing~~ Add tab sizing Dec 6, 2019

carlos-zamora approved these changes Dec 6, 2019

View reviewed changes

doc/cascadia/SettingsSchema.md Outdated Show resolved Hide resolved

Update doc/cascadia/SettingsSchema.md

394b166

Co-Authored-By: Carlos Zamora <carlos.zamora@microsoft.com>

DHowett-MSFT previously requested changes Dec 6, 2019

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 6, 2019

zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Dec 9, 2019

zadjii-msft requested changes Dec 9, 2019

View reviewed changes

zadjii-msft mentioned this pull request Dec 10, 2019

Feature Request: Tab title max length/truncation #3899

Closed

vadimkantorov mentioned this pull request Dec 13, 2019

Default tab title is super-long, only 3 tabs fit the screen #3947

Closed

ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Dec 20, 2019

ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Dec 20, 2019

ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Dec 27, 2019

ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Dec 28, 2019

cinnamon-msft mentioned this pull request Jan 3, 2020

Spec for Tab Sizing #4104

Merged

5 tasks

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 3, 2020

updated variable names to match spec

71fb468

cinnamon-msft changed the title ~~Add tab sizing~~ Add tab width modes: equal and titleLength Jan 9, 2020

zadjii-msft approved these changes Jan 9, 2020

View reviewed changes

DHowett-MSFT suggested changes Jan 9, 2020

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 9, 2020

added to defaults.json

d6a1555

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 9, 2020

cinnamon-msft requested a review from DHowett-MSFT January 9, 2020 23:24

DHowett-MSFT approved these changes Jan 9, 2020

View reviewed changes

cinnamon-msft added 2 commits January 9, 2020 15:38

merged with master

78c4f79

fixed merge conflict

507b457

cinnamon-msft merged commit cbdfd0e into master Jan 10, 2020

cinnamon-msft deleted the cinnamon/tab-sizing branch January 10, 2020 00:16

miniksa pushed a commit that referenced this pull request Feb 9, 2021

Spec for Tab Sizing (#4104)

cad7954

This is the spec for #597 I am proposing the `tabWidthMode` feature be added first, then `tabWidthMin` and `tabWidthMax` be added in a later release. PR: #3876

zadjii-msft mentioned this pull request Apr 20, 2023

More complete tab sizing configurations #597

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tab width modes: equal and titleLength #3876

Add tab width modes: equal and titleLength #3876

cinnamon-msft commented Dec 6, 2019 •

edited by DHowett-MSFT

Loading

carlos-zamora left a comment

DHowett-MSFT left a comment

DHowett-MSFT commented Dec 6, 2019

DHowett-MSFT commented Dec 6, 2019

rkeithhill commented Dec 7, 2019

zadjii-msft left a comment

zadjii-msft Dec 9, 2019

zadjii-msft commented Dec 9, 2019

vadimkantorov commented Dec 13, 2019

ghost commented Dec 20, 2019

zadjii-msft commented Dec 20, 2019

ghost commented Dec 27, 2019

rkeithhill commented Dec 28, 2019

miniksa commented Dec 30, 2019

cinnamon-msft commented Jan 3, 2020

zadjii-msft left a comment

DHowett-MSFT left a comment

ghost commented Jan 14, 2020

Add tab width modes: equal and titleLength #3876

Add tab width modes: equal and titleLength #3876

Conversation

cinnamon-msft commented Dec 6, 2019 • edited by DHowett-MSFT Loading

Summary of the Pull Request

carlos-zamora left a comment

Choose a reason for hiding this comment

DHowett-MSFT left a comment

Choose a reason for hiding this comment

DHowett-MSFT commented Dec 6, 2019

DHowett-MSFT commented Dec 6, 2019

rkeithhill commented Dec 7, 2019

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft Dec 9, 2019

Choose a reason for hiding this comment

zadjii-msft commented Dec 9, 2019

vadimkantorov commented Dec 13, 2019

ghost commented Dec 20, 2019

zadjii-msft commented Dec 20, 2019

ghost commented Dec 27, 2019

rkeithhill commented Dec 28, 2019

miniksa commented Dec 30, 2019

cinnamon-msft commented Jan 3, 2020

zadjii-msft left a comment

Choose a reason for hiding this comment

DHowett-MSFT left a comment

Choose a reason for hiding this comment

ghost commented Jan 14, 2020

cinnamon-msft commented Dec 6, 2019 •

edited by DHowett-MSFT

Loading