Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer text buffer redrawing #3089

Closed

Conversation

skyline75489
Copy link
Collaborator

Summary of the Pull Request

This is a draft PR that's intended to defer all kinds of redrawing.

References

#2960 #3075

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Coming from #2960, combined with an inspiring issue from #3075 , we are indeed doing a lot of unnecessary redrawing when there are still incoming text.

I'd love to hear @miniksa 's thought on this.

Validation Steps Performed

@skyline75489
Copy link
Collaborator Author

I've tried several things and it turns out this can't be accomplished easily. To make WT more like iTerm2, we'll need to rerwrite the entire renderering pipeline to process as much input as we could before actually renderering it to screen. I'll close this for now. If anyone wants to pick it, feel free to do so.

@skyline75489
Copy link
Collaborator Author

I've tried several things and it turns out this can't be accomplished easily. To make WT more like iTerm2, we'll need to rerwrite the entire renderering pipeline to process as much input as we could before actually renderering it to screen. I'll close this for now. If anyone wants to pick it, feel free to do so.

@skyline75489 skyline75489 deleted the fix/deferOverallRedrawing branch February 9, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant