Make sure to apply the theme on load of the application #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1913. _AplyTheme raises an event for the IslandWindow to handle and actually apply the theme, so we don't _really_ need to worry about it, but we do need to worry for ContentDialogs.
zadjii-msft
added
Area-UserInterface
DHowett-MSFT
approved these changes
Jul 25, 2019
miniksa
approved these changes
Jul 25, 2019
29 tasks
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 26, 2019
Fixes microsoft#1913. _AplyTheme raises an event for the IslandWindow to handle and actually apply the theme, so we don't _really_ need to worry about it, but we do need to worry for ContentDialogs.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1913.
_AplyTheme raises an event for the IslandWindow to handle and actually apply
the theme, so we don't really need to worry about it, but we do need to
worry for ContentDialogs.
PR Checklist