Optimize DCS performance with batch processing #19640
Open
+541
−426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR is a lot spicier than #19639. I think I did it correctly, but it's probably better to wait until after we released the next WT version. |
DHowett
reviewed
Dec 10, 2025
| // intentionally, it's far more likely now that we're looking at a broken up sequence. | ||
| // The most common win32-input-mode is ConPTY itself after all, and we never emit | ||
| // \x1b{some char} once it's enabled. | ||
| if (_isEngineForInput) |
Member
There was a problem hiding this comment.
in my work on OSC sequences i realized... I don't think caching actually does anything for the output engine any longer. The cached sequence is never emitted because OutputStateMachineEngine::ActionPassThroughString does nothing.
Which makes sense, actually. Since ConPTY became passthrough mode, there's no reason to cache. We just yeet everything through.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps performance of sixels by around 20%. More importantly, this bumps performance of any future optimized DCS code (e.g. tmux control mode) by practically infinite%, because we can pass through payloads unmodified.
Validation Steps Performed