Fix unfocusedBackground being used as active tab color #19424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Oct 9, 2025
DHowett
reviewed
Oct 9, 2025
|
|
||
| // TabViewItem.Background | ||
| currentDictionary.Insert(winrt::box_value(L"TabViewItemHeaderBackground"), deselectedTabBrush); | ||
| currentDictionary.Insert(winrt::box_value(L"TabViewItemHeaderBackground"), selectedTabBrush); |
Member
There was a problem hiding this comment.
wait, this doesn't cause Terminal to look wrong on the default themes? The resource makes it sound like it MUST be the deselected one... what happened?
Member
Author
There was a problem hiding this comment.
Just downloaded the build unpackaged and tested it with no theme set (with and without high contrast mode). Still looks correct.
I'm with you, the resource sounds like it should be the deselected one though haha. But when I tested it with the "Snazzy" theme from the bug report (unfocused = Red, selected = Green), I noticed that there was actually a green outline on the selected tab:
I bet the colors are layered or something like that.
DHowett
pushed a commit
that referenced
this pull request
Nov 24, 2025
Turns out that the `"TabViewItemHeaderBackground"` resource should be set to the _selected_ color instead of the _deselected_ color. In 1.22, (pre-#18109) we actually didn't set this resource. But we do actually need it for high contrast mode! (verified) ✅ High contrast mode looks right ✅ "Snazzy" theme from bug report looks right Closes #19343 (cherry picked from commit b62cad6) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgfrGvM Service-Version: 1.23
DHowett
pushed a commit
that referenced
this pull request
Nov 24, 2025
## Summary of the Pull Request Turns out that the `"TabViewItemHeaderBackground"` resource should be set to the _selected_ color instead of the _deselected_ color. In 1.22, (pre-#18109) we actually didn't set this resource. But we do actually need it for high contrast mode! (verified) ## Validation Steps Performed ✅ High contrast mode looks right ✅ "Snazzy" theme from bug report looks right ## PR Checklist Closes #19343 (cherry picked from commit b62cad6) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgfrGvI Service-Version: 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Turns out that the
"TabViewItemHeaderBackground"resource should be set to the selected color instead of the deselected color.In 1.22, (pre-#18109) we actually didn't set this resource. But we do actually need it for high contrast mode! (verified)
Validation Steps Performed
✅ High contrast mode looks right
✅ "Snazzy" theme from bug report looks right
PR Checklist
Closes #19343