Move newTabMenu creation to Settings Fixups #19353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I fixed the tests by removing the write-to-disk step from this fixup. I didn't want to add a |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
carlos-zamora
approved these changes
Sep 16, 2025
lhecker
approved these changes
Sep 16, 2025
DHowett
added a commit
that referenced
this pull request
Sep 16, 2025
Some of the other settings fixups require there to be a valid NewTabMenu, rather than just a temporary object. Since the resolving all the menu entries after loading already forces the user to have a `newTabMenu`, let's just codify it as a real fixup. I've moved the SSH folder fixup after the settings fixup because it relies on there being a NTM. I decided not to make this fixup write back to the user's settings. There are a couple reasons for this, all of which are flimsy. - There are a number of tests that test fixup behavior, especially those around actions, which would need to be updated for this new mandatory key. I did not think it proper to add `newTabMenu` to ten unrelated tests that only contain actions (for example.) - We actually don't currently have mandatory keys. But this one was always being added anyway, in a later phase... - It's consistent with the existing behavior. Closes #19356 (cherry picked from commit e80aadd) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzge0HjU Service-Version: 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the other settings fixups require there to be a valid NewTabMenu, rather than just a temporary object. Since the resolving all the menu entries after loading already forces the user to have a
newTabMenu, let's just codify it as a real fixup.I've moved the SSH folder fixup after the settings fixup because it relies on there being a NTM.
I decided not to make this fixup write back to the user's settings. There are a couple reasons for this, all of which are flimsy.
newTabMenuto ten unrelated tests that only contain actions (for example.)Closes #19356