Filter the Command Palette in English in addition to locale #19166
+419
−258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
commented
Jul 23, 2025
Comment on lines
+20
to
+25
| static bool shouldShowSubtitles = [] { | ||
| auto ctx = winrt::Windows::ApplicationModel::Resources::Core::ResourceContext::GetForViewIndependentUse(); | ||
| auto qv = ctx.QualifierValues(); | ||
| auto lang = qv.TryLookup(L"language"); | ||
| return lang != L"en-US"; | ||
| }(); |
DHowett
commented
Jul 23, 2025
| auto itemSubtitle = _Item.Subtitle(); | ||
| int32_t subtitleWeight = 0; | ||
| std::tie(subtitleSegments, subtitleWeight) = _matchedSegmentsAndWeight(_pattern, itemSubtitle); | ||
| weight += subtitleWeight; |
There was a problem hiding this comment.
OPEN DISCUSSION (cc @e82eric) how do we combine weights when we have multiple haystacks
There was a problem hiding this comment.
for the localization use case, looking at the screenshots, I would lean towards using the max of the 2 scores. I think where "split" gets matched in both the localized and English haystacks adding them would cause the items with English chars/matches in the localized version to score unfairly high compared to the ones that don't.
There was a problem hiding this comment.
Excellent excellent call. I've done this :)
DHowett
force-pushed
the
dev/duhowett/multi-lingual-command-palette
branch
from
703afff to
497b8f2
Compare
DHowett
force-pushed
the
dev/duhowett/command-name-resource-or-string
branch
from
996b06c to
e867912
Compare
Base automatically changed from
dev/duhowett/command-name-resource-or-string
to
main
July 24, 2025 17:53
DHowett
force-pushed
the
dev/duhowett/multi-lingual-command-palette
branch
from
df38587 to
38b9a7d
Compare
microsoft-github-policy-service
bot
added
Issue-Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this work is changing
Command::Name(and its descendants likeGenerateName) to support looking up names in English and in the local language.Refs #19130, #19131, #19132, #19165
Closes #7039