Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the scrollbar postiton on scrollToMark #13291

Merged
3 commits merged into from
Jun 16, 2022
Merged

Update the scrollbar postiton on scrollToMark #13291

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13d48a9
Update the scrollbar postiton on `scrollToMark`
zadjii-msft Jun 13, 2022
cd28a8b
can I get a spellbot.exe on .git/pre-commit?
zadjii-msft Jun 13, 2022
246cc9d
Update src/cascadia/TerminalControl/ControlCore.cpp
zadjii-msft Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/cascadia/TerminalControl/ControlCore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2017,19 +2017,27 @@ namespace winrt::Microsoft::Terminal::Control::implementation
}
}

const auto viewHeight = ViewHeight();
const auto bufferSize = BufferHeight();

// UserScrollViewport, to update the Terminal about where the viewport should be
// then raise a _terminalScrollPositionChanged to inform the control to update the scrollbar.
if (tgt.has_value())
{
UserScrollViewport(tgt->start.y);
_terminalScrollPositionChanged(tgt->start.y, viewHeight, bufferSize);
}
else
{
if (direction == ScrollToMarkDirection::Last || direction == ScrollToMarkDirection::Next)
{
UserScrollViewport(BufferHeight());
_terminalScrollPositionChanged(BufferHeight(), viewHeight, bufferSize);
}
else if (direction == ScrollToMarkDirection::First || direction == ScrollToMarkDirection::Previous)
{
UserScrollViewport(0);
_terminalScrollPositionChanged(0, viewHeight, bufferSize);
}
}
}
Expand Down