Wrap these commands with quotes #11807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
the
Area-Build
ghost
added
Issue-Bug
lhecker
previously approved these changes
Nov 22, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This comment has been minimized.
This comment has been minimized.
lhecker
approved these changes
Nov 23, 2021
DHowett
approved these changes
Nov 23, 2021
| <AdditionalIncludeDirectories>$(IntermediateOutputPath);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | ||
| </ResourceCompile> | ||
| </ItemDefinitionGroup> | ||
| <!-- If you don't include a '.' at the end of the $(IntermediateOutputPath), |
Member
There was a problem hiding this comment.
it was never confused before -- is this an escaping issue?
Member
There was a problem hiding this comment.
right, it's confused by the trailing \"
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty exactly following the diff from #917. These paths weren't wrapped in
"s, so building the solution in a directory with a space in it would explode.Closes #917.
Turns out, the diff provided by that user wasn't exactly right. I've tested building in a directory with spaces now, and this seems to work.
Also caught a bug in the Generate Feature Flags script.