Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globalSummon.dropdownDuration not saving correctly #11401

Merged
1 commit merged into from
Oct 4, 2021
Merged

Fix globalSummon.dropdownDuration not saving correctly #11401

1 commit merged into from
Oct 4, 2021

Conversation

NotWearingPants
Copy link
Contributor

Summary of the Pull Request

In settings.json there's an actions array to configure keybindings.
The action globalSummon has an argument called dropdownDuration.
The settings editor deleted this argument from the settings because of a typo in ActionArgs.h.

PR Checklist

Detailed Description of the Pull Request / Additional comments

There was a JsonUtils::GetValueForKey instead of a JsonUtils::SetValueForKey.
This is what happens when such code is not autogenerated.

Validation Steps Performed

None

zadjii-msft
zadjii-msft approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥚 -> 🤕

thanks

@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Oct 4, 2021
@lhecker lhecker added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. AutoMerge Marked for automatic merge by the bot when requirements are met labels Oct 4, 2021
@ghost
Copy link

ghost commented Oct 4, 2021

Hello @lhecker!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e5180fe into microsoft:main Oct 4, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 20, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@DHowett DHowett Awaiting requested review from DHowett

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

globalSummon's dropdownDuration is deleted when saving settings
3 participants
@NotWearingPants @lhecker @zadjii-msft