Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render "intense" text as bright by default #10958

Merged
1 commit merged into from
Aug 16, 2021
Merged

Render "intense" text as bright by default #10958

1 commit merged into from
Aug 16, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Aug 16, 2021 •
edited by DHowett
Loading

From discussion at #10678, we will ship with "intense" as bright for now until we fix text getting cut off by some bold fonts.

zadjii-msft
zadjii-msft approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@DHowett DHowett added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Aug 16, 2021
@DHowett
Copy link
Member

DHowett commented Aug 16, 2021

@msftbot merge this in 1 mileway

@ghost
Copy link

ghost commented Aug 16, 2021

Hello @DHowett!

I think you told me that you want to delay the approval for a certain amount of time, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@DHowett
Copy link
Member

DHowett commented Aug 16, 2021

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 16, 2021
@ghost
Copy link

ghost commented Aug 16, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 16 Aug 2021 19:58:39 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 59f184a into main Aug 16, 2021
@ghost ghost deleted the dev/pabhoj/bold_default_fix branch August 16, 2021 19:59
DHowett pushed a commit that referenced this pull request Aug 25, 2021
@PankajBhojwani @DHowett
Render "intense" text as bright by default (#10958)
cc0bc48 
From discussion at #10678, we will ship with "intense" as bright for now until we fix text getting cut off by some bold fonts.
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Aug 25, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.10.2383.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PankajBhojwani @DHowett @lhecker @zadjii-msft