Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Xaml Toolkit App Host to 6.1.3 #10640

Merged
1 commit merged into from
Jul 12, 2021
Merged

Update Xaml Toolkit App Host to 6.1.3 #10640

1 commit merged into from
Jul 12, 2021

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jul 12, 2021

This is required for some inbox compliance tasks regarding symbol availability.

@DHowett
Update Xaml Toolkit App Host to 6.1.3
51b1ca3 
This is required for some inbox compliance tasks regarding symbol availability.
zadjii-msft
zadjii-msft approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of me fears that this will break the App ref counting hack we were doing in WindowsTerminal or something else that we won't notice till the release build is cut & shipped

@carlos-zamora
Copy link
Member

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 12, 2021
@DHowett
Copy link
Member Author

DHowett commented Jul 12, 2021

@msftbot merge this in 1 minute ?

@ghost
Copy link

ghost commented Jul 12, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 12 Jul 2021 22:57:35 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Jul 12, 2021
@ghost ghost merged commit e37fd5e into main Jul 12, 2021
@ghost ghost deleted the dev/duhowett/xa613 branch July 12, 2021 22:58
DHowett added a commit that referenced this pull request Jul 12, 2021
@DHowett
Update Xaml Toolkit App Host to 6.1.3 (#10640)
bae1793 
This is required for some inbox compliance tasks regarding symbol availability.

(cherry picked from commit e37fd5e)
fasdqw222 added a commit to fasdqw222/terminal that referenced this pull request Jul 13, 2021
@fasdqw222
Revert "Update Xaml Toolkit App Host to 6.1.3 (microsoft#10640)"
27e0535 
This reverts commit e37fd5e.
@ghost
Copy link

ghost commented Jul 14, 2021

🎉Windows Terminal Preview v1.10.1933.0 has been released which incorporates this pull request.:tada:

Handy links:

@DHowett DHowett removed zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Aug 25, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DHowett @carlos-zamora @zadjii-msft