Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpf: fix the TerminalTheme struct to marshal the same on all platforms #10486

Merged
1 commit merged into from
Jun 22, 2021
Merged

wpf: fix the TerminalTheme struct to marshal the same on all platforms #10486

1 commit merged into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. wpf: fix the TerminalTheme struct to be marshallable on all platforms 

    The CursorStyle enum is declared as being of type `uint` on the C# side,
but as `size_t` on the C++ side. There's a C# size_t impostor we could
use, System.UIntPtr, but I don't want to risk changing the public API of
TerminalTheme and I don't know if it can be used as a base type for an
enum value.

Anyway, since we don't have more than four billion cursor types I chose
to narrow the field to a uint32_t and unpack it in TerminalSetTheme.

Fixes #10485
    @DHowett
    DHowett committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    b7ab0f5 View commit details
    Browse the repository at this point in the history