Group font options in the json into a single object

[PankajBhojwani]

Summary of the Pull Request

Introduces FontConfig, an object that isolates font-related settings in our profiles

Users can now define font settings in their json as so:

"font":{
    "face": "Consolas",
    "size": 12
}

Backwards compatible with the currently expected way of defining font settings in the json, note however that upon hitting 'Save' in the SUI, these settings will be rewritten to the font-object style in the json (as above).

References

#1790

PR Checklist

• Closes #6049
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated.
• I work here

Validation Steps Performed

Existing functionality works, new functionality works

[carlos-zamora]

This looks great! Really just want...

• resolution on the "remove 'font' prefix" question
• Testing: fix the roundtrip serialization test (I guarantee you that one is failing; It's a local test)
• Testing: add a test for handling the legacy json format. Just to make sure nobody removes that code sometime in the future.

[DHowett]

block for spec review?

[carlos-zamora]

Ah shoot! Don't forget to update the schema and docs!!

[carlos-zamora]

block for spec review?

Wait... which spec? #10383 seems more relevant, but is closed. And #10457 seems to just build on it.

[PankajBhojwani]

block for spec review?

I thought we agreed this doesn't need a spec since its just grouping our current font options together into 1 object and doesn't add/change any current functionality (if I'm mistaken I can add it to #10457).

[PankajBhojwani]

Ah shoot! Don't forget to update the schema and docs!!

Thanks for the reminder! Updated schema

[lhecker]

Taking those arguments by value will force the reference count to be incremented for the duration of the call. It's probably a good idea to just take source as a pointer or reference as you aren't storing it elsewhere for later.
Especially because the code around winrt::com_ptr::copy_from feels a bit non-obvious / roundabout to me.

[PankajBhojwani]

So this was intentionally done this way to maintain consistency with Profile::CopySettings and AppearanceConfig::CopyAppearance and I'd like to keep it this way because of that

[lhecker]

I'm convinced that we'll have to start to clean up such code in the future though.
Isn't it quite seldom that you touch all places simultaneously to clean something up? I don't believe there's (in a rhetoric sense) "any better time to do it than now", as such house-keeping tasks will always be unrelated to any actual task by their nature.

[carlos-zamora]

Don't forget to update the docs too!

[ghost]

🎉Windows Terminal Preview v1.10.1933.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download