Feature Request - Restore closed tab

[AClerbois]

Hello,

I'd suggest a restore tag feature like in internet browser. For example, you close a tab and press [CTRL] + [SHIFT] + [T] and that will restore the latest tab closed.

May be without the context in the first step but with the latest path.

P.S. : Thank you for your awesome project,, I'm very excited to use the final preview version with the new font.

[zadjii-msft]

So tracking the most recently closed tab wouldn't be that hard. We could keep a stack of profiles as we close them, and just pop from that stack when we want to reopen one. That's not too hard.

What is hard is restoring state. Even restoring the path of the executable that was running might be incredibly tricky - can we get the cwd of an arbitrary executable? What if the executable was ssh, which in some directory in a remote machine? We certainly wouldn't be able to restore that connection. What if the path no longer exists? If we CreateProcess a process in a directory that doesn't exist, what happens? Do we just default to the profile's default? What if your cmd.exe profile was running powershell, and powershell had changed to some other directory? We can't restore the process tree, and because this is Windows, there isn't the concept of a "foreground" process attached to a conpty, so we'd have to default to using the state from the executable at the root of the process tree.

Just some thoughts off the top of my head. I'm sure @malxau actually has a lot more on this if I remember my email inbox correctly.

I want to make sure that this issue specifically tracks "restoring the last closed tab's profile" and not "restore it's state" because the former is easy and the latter is hard. We should probably have more discussion of the latter in a new issue, #961.

---

Actually now that I've typed #961 up, I had an idea. This might have to be something that the user opts in to, but we could theoretically just keep the TermControls from the N most recently closed tabs panes alive in the stack, and when the user reopens the tab, we just put the control back into the tab pane. I'm suggesting this is opt-in, since we'd be keeping some number of controls alive, including all the processes attached to them. This would definitely seem like a memory leak, unless the user has opted in to this behavior, and the user would almost certainly

1. need to know this was happening
2. have a way to manually shut these saved instances down

[desmondkung]

I don't think restoring state is a good idea, especially from a security perspective. If I'm a bad actor and try to run terminal that restores state, it's like opening a box of surprises, which might make my work easier.

[Rosefield]

In light of the changes for #766 the version of this which is just re-opening the profile should be relatively easy

• When closing a pane call Pane::GetTerminalArgsForPane

  terminal/src/cascadia/TerminalApp/Pane.cpp

  Line 122 in 479ef26

  NewTerminalArgs Pane::GetTerminalArgsForPane() const

  
  on the closed pane and add that to a stack of recently closed panes
• To restore the recently closed pane either make a new tab using those new terminal args, or make an automatic split on the currently focused pane using those new terminal args.
• To save/restore multiple panes you can call Pane::BuildStartupActions to get the list of actions to restore that tree of panes, and depending on if you are making a new tab or just attaching to the current pane you prepend a new tab / split pane command like the logic in TerminalTab::BuildStartupActions.

  terminal/src/cascadia/TerminalApp/TerminalTab.cpp

  Lines 454 to 467 in 479ef26

  	std::vector<ActionAndArgs> TerminalTab::BuildStartupActions() const
  	{
  	// Give initial ids (0 for the child created with this tab,
  	// 1 for the child after the first split.
  	auto state = _rootPane->BuildStartupActions(0, 1);
  	{
  	ActionAndArgs newTabAction{};
  	newTabAction.Action(ShortcutAction::NewTab);
  	NewTabArgs newTabArgs{ state.firstPane->GetTerminalArgsForPane() };
  	newTabAction.Args(newTabArgs);
  	state.args.emplace(state.args.begin(), std::move(newTabAction));
  	}

  
  The history stack could just be a std::vector<std::vector<ActionAndArgs>> and restoring would then just be popping and executing a list of actions.

[zadjii-msft]

The implementation I had considered was simply hanging on to the last N TermControls when they get closed, to allow someone to fully restore that many panes. That way, if someone accidentally closed a long running command, then the whole command would come back with it.

Now, that of course had the downside that closing a pane wouldn't necessarily terminate the process in it. So your way is probably good even in addition to the active command restore

[DHowett]

When we market this feature, we should be very clear on what it does. If I recall correctly:

This does not restore the application running in the closed tab. The restore action restores a facsimilie of the closed session, but the application that was running in it doesn't keep running.

[ghost]

🎉This issue was addressed in #11471, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.:tada:

Handy links:

• Release Notes
• Store Download

[tJKkeZQoZlcssuXjVjNerQ]

🎉Este problema se solucionó en #11471, que ahora se ha publicado correctamente como .Windows Terminal Preview v1.13.10336.0🎉

Enlaces prácticos:

• Notas
• Descargar tienda

Aun existe un loop al iniciar el terminal. ocurre despues de guardar los cambios del terminal y poner el perfil que inicie como administrador y al abrirlo de nuevo. queda abriendo y cerrando el proceso pero nunca lo muestra.

[swinder0161]

The problem with this is the tab position is not restored, if tab closed is first one, the restored tab is the last one.
the position should also be restored