Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the creation of the jumplist entries #7791

Closed
zadjii-msft opened this issue Oct 1, 2020 · 3 comments · Fixed by #7978
Closed

Optimize the creation of the jumplist entries #7791

zadjii-msft opened this issue Oct 1, 2020 · 3 comments · Fixed by #7978
Assignees
@PankajBhojwani
Labels
Area-Performance Performance-related issue Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.5

Comments

@zadjii-msft
Copy link
Member

Taken from some rudimentary tracing that was done in #7774:

CShellLink::SetPath seems to be quite performance intensive for some reason. This is probably unnecessarily slowing down our startup.

Idea: maybe we could dispatch a background thread to update the jumplist? We don't really need to do that on the main thread, right?
@zadjii-msft zadjii-msft added Area-Performance Performance-related issue Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Oct 1, 2020
@zadjii-msft zadjii-msft added this to the Terminal v1.5 milestone Oct 1, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 1, 2020
@DHowett
Copy link
Member

DHowett commented Oct 1, 2020

Yeah we should def dispatch this to the background with a copy of the profile list so it doesn’t get all mutated under us if there’s two quick back2back saves

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 1, 2020
@zadjii-msft zadjii-msft self-assigned this Oct 1, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 5, 2020
Closed
@PankajBhojwani PankajBhojwani mentioned this issue Oct 20, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 20, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Oct 23, 2020
DHowett pushed a commit that referenced this issue Oct 23, 2020
@PankajBhojwani
Move jumplist creation to background thread (#7978)
4f39e8e 
Move jumplist creation to a background thread, as it
does not need to be on the main thread

Closes #7791
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 23, 2020
DHowett pushed a commit that referenced this issue Oct 27, 2020
@PankajBhojwani @DHowett
Move jumplist creation to background thread (#7978)
fe4f0f3 
Move jumplist creation to a background thread, as it
does not need to be on the main thread

Closes #7791

(cherry picked from commit 4f39e8e)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7978, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7978, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Performance Performance-related issue Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.5
Development

Successfully merging a pull request may close this issue.

Move jumplist creation to background thread microsoft/terminal
3 participants
@DHowett @zadjii-msft @PankajBhojwani