Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryDuplicateBadTab and TryDuplicateBadPane unit tests are hanging when run locally #5169

Closed
j4james opened this issue Mar 29, 2020 · 1 comment · Fixed by #7333
Closed

TryDuplicateBadTab and TryDuplicateBadPane unit tests are hanging when run locally #5169

j4james opened this issue Mar 29, 2020 · 1 comment · Fixed by #7333
Assignees
@zadjii-msft
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Bisect Somebody's got to go through and do the needful. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.x

Comments

@j4james
Copy link
Collaborator

j4james commented Mar 29, 2020

Environment

Windows build number: Version 10.0.18362.657
Windows Terminal version (if applicable): Commit 28d108b

Steps to reproduce

  1. Build the OpenConsole solution from a recent commit
  2. Run the unit test with runut.cmd /name:*TabTests::TryDuplicate*

Expected behavior

The unit tests should execute successfully.

Actual behavior

The TestHostApp window opens up and the test then appears to be stuck. Closing the window manually doesn't help, but if you instead kill the TestHostApp process, it will at least continue with the rest of the tests.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 29, 2020
@zadjii-msft
Copy link
Member

That's not what you want to hear 😞. I wonder when this regressed - I'd bet it's the combo of #5051 with #5090, but I can't be sure ATM

@zadjii-msft zadjii-msft added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Mar 30, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 30, 2020
@zadjii-msft zadjii-msft added the Needs-Bisect Somebody's got to go through and do the needful. label Mar 30, 2020
@zadjii-msft zadjii-msft self-assigned this Mar 31, 2020
@zadjii-msft zadjii-msft mentioned this issue Mar 31, 2020
Merged
3 tasks
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.x milestone Apr 1, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 1, 2020
ghost pushed a commit that referenced this issue Apr 1, 2020
@zadjii-msft
Use an Automatic split for splitPane by default (#5194)
a621a6f 
## Summary of the Pull Request

You no longer _need_ to specify the `split` argument to `splitPane`, it will default to `Automatic` instead of `None`


## PR Checklist
* [x] Closes a discussion we had in team sync
* [x] I work here
* [x] Tests updated
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

Also disables the tests that are broken in #5169 while I investigate
@miniksa miniksa mentioned this issue Aug 13, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Aug 18, 2020
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 18, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Bisect Somebody's got to go through and do the needful. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Fix broken localtests microsoft/terminal
3 participants
@j4james @DHowett-MSFT @zadjii-msft