-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Description
Description of the new feature/enhancement
If you have the dropdown open...
Altclick a profile to open anautosized pane of the profile.
related to #1000
Alternative Implementations
- no-auto
- Alt+Click: vertical split
- Alt+Shift+Click: horizontal split
- customizable split
- right click opens a flyout with the options "vertical", "horizontal", "auto"
- Alt+Click/Invoke behavior is defined in your profiles.json
But why bother?
I'm a very visual person. I like to see what profiles I have before opening one, personally.
Also, I forget what each index for the new-pane key binding maps to which profile. So I constantly find myself opening a new pane, seeing that it's the wrong one, closing it, checking the drop down, figuring out the index, then trying the correct key binding. That's on me for being a very visual person, but being able to short-circuit the process into an alt+click would feel pretty natural, I think.
Proposed technical implementation details
This would be pretty easy to implement, actually. For input, we'd just look at how the Settings flyout menu is handled. Then we just call the new-pane function off of TermApp with the profile that we targeted.
If we go with the alternative implementations, the above implementation is fundamentally the same. We'd just call the function with different parameters.
Comments after #5928
#5928 added the ability to split pane by alt+clicking a profile in the new tab flyout. This doesn't entirely close this issue. Though now you can open a pane without keybindings, the user should still be able to choose whether they want a horizontal or vertical pane. This issue has been promoted to track that scenario in particular.