Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialPosition (and others) should be available as commandline args #4620

Closed
bruceoberg opened this issue Feb 17, 2020 · 13 comments · Fixed by #13730
Closed

initialPosition (and others) should be available as commandline args #4620

bruceoberg opened this issue Feb 17, 2020 · 13 comments · Fixed by #13730
Labels
Area-Commandline wt.exe's commandline arguments good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@bruceoberg
Copy link

bruceoberg commented Feb 17, 2020

initial issue description mentions "per-profile", but consider that they could be commandline arguments

Description of the new feature/enhancement

i want to create multiple shortcuts that launch wt at different sizes and screen positions. i'm talking about multiple instances of wt, not multiple tabs within wt.

however, the initialPosition setting is global and cannot be overridden on a per-profile basis. ditto for initialRows, initialCols and launchMode. because these are global settings, any shortcut can only launch wt at one position and size.

i'm looking for parity with CMD here. a shortcut to CMD has a bunch of settings tabs, including screen size and position. i have shortcuts to launch CMD in different places for various reasons. i'd like to use shortcuts to launch wt instead.

Proposed technical implementation details (optional)

allow initialPosition, initialRows, initialCols and launchMode to be specified within a profile in settings.json. if that profile is the main one active at launch time, then use them instead of the globals.

@bruceoberg bruceoberg added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 17, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 17, 2020
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-Commandline wt.exe's commandline arguments labels Feb 18, 2020
@DHowett-MSFT
Copy link
Contributor

I'd prefer to let commandline arguments solve this one, honestly. I don't like the idea of profiles whose settings override application-level settings, because that opens up a pretty big can of worms.
To that end, I've renamed this. Please feel free to complain: I want to make sure I'm not shutting down valuable discussion here.

@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 21, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 21, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.x milestone Feb 21, 2020
@DHowett-MSFT DHowett-MSFT added the Help Wanted We encourage anyone to jump in on these. label Feb 21, 2020
@DHowett-MSFT DHowett-MSFT changed the title initialPosition (and others) should be available as per-profile settings initialPosition (and others) should be available as commandline args Feb 21, 2020
@bruceoberg
Copy link
Author

command line arguments is a fine solution. i would have no complaints.

@dpokluda
Copy link

+1 command line arguments would work for me as well

@bruceoberg
Copy link
Author

i think the strongest reason for this is that CMD has it and i depend on the feature. @DHowett-MSFT @cinnamon-msft should i be trying to write this myself and then send a PR? i can't what sort of priority this request has.

@DHowett
Copy link
Member

DHowett commented Jan 17, 2021

@bruceoberg cmd has a feature where you can specify the initial position by commandline argument?

As the engineering owner for cmd, I'm surprised to hear that. Do you have any more details?

@DHowett
Copy link
Member

DHowett commented Jan 17, 2021

Oh, I see. Per-profile. It doesn't really have that: it's per shortcut file or exe, for which the equivalent is a terminal shortcut that spawns wt with arguments. We are not introducing launch settings to profiles, because they don't make sense at that level. Sorry.

@DHowett
Copy link
Member

DHowett commented Jan 17, 2021

(i got tricked by my own re-titling of your issue. Sorry about that!)

@zadjii-msft zadjii-msft added the good first issue This is a fix that might be easier for someone to do as a first contribution label Feb 9, 2021
@bruceoberg
Copy link
Author

so i will never be able to create two shortcuts that launch two wt instances in two different positions? i don't need per-profile settings, i just need a command-line option to set the position and size.

@zadjii-msft
Copy link
Member

I don't think anyone ever said that - DHowett just confused himself 😆

We definitely want to add --initialPostition, --initialRows, --initialCols to the commandline arguments available. Then, you could use those in a shortcut to set the position and size of the Terminal.

@arkanario
Copy link

Any news on this subject?

How to start a new windows terminal from command line in a specific location and with specific window size?

@zadjii-msft
Copy link
Member

Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?
image
That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread ☺️

@zadjii-msft
Copy link
Member

Notes from #13307: Make sure there's a sentinel value or flag or something to also allow CW_USEDEFAULT as the position

@zadjii-msft zadjii-msft modified the milestones: 22H1, Up Next Aug 3, 2022
@ghost ghost added the In-PR This issue has a related PR label Aug 12, 2022
carlos-zamora pushed a commit that referenced this issue Oct 7, 2022
Adds `--pos`, and `--size` commandline arguments to `wt`.

Closes #4620
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Oct 7, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #13730, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants