-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctrl + # not being processed by Bash correctly #3507
Comments
CTRL-6 does not seem to under CMD (with the Windows version of vim), and also not under WSL (Ubuntu). |
Could you share your |
We need to check if this is just physical numpad, the number key row, or both. Also how it works relative to the numpad key. |
This is almost certainly the number key row. Digits 2 to 8 are supposed to generate some of the C0 control characters when combined with a As far as I know, the numpad keys aren't meant to be affected by the |
Here's my profiles.json. There's not much changed besides some look and feel. And yes, it's the number key row.
|
As i was intending to say, this has NOTHING to do with user-profiles. It is not working under different profiles so it's a problem of 'Windows Terminal' ! That why i am inserting my profile (BTW: its the default profile!):
|
@j4james has it right - we should be using that table to send specific characters on C-#. This isn't really even a Windows Terminal problem, this is a conhost problem. |
By the way, I'm using emacs with windows terminal and it seems emacs fails to detect key bindings like |
A simple way to check if keys are sent through is to run |
## Summary of the Pull Request Fixes the <kbd>Ctrl+Num</kbd> keys in both conhost and the Terminal. These keys are supposed to be mapped to specific characters according to [this doc](https://vt100.net/docs/vt220-rm/table3-5.html). Now we actually handle them correctly. ## PR Checklist * [x] Closes #3507 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * Ran test * tested in `gnome-terminal` with `showkeys -a` * tested in conhost with `showkeys -a` * tested in Windows Terminal with `showkeys -a`
## Summary of the Pull Request Fixes the <kbd>Ctrl+Num</kbd> keys in both conhost and the Terminal. These keys are supposed to be mapped to specific characters according to [this doc](https://vt100.net/docs/vt220-rm/table3-5.html). Now we actually handle them correctly. ## PR Checklist * [x] Closes #3507 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * Ran test * tested in `gnome-terminal` with `showkeys -a` * tested in conhost with `showkeys -a` * tested in Windows Terminal with `showkeys -a` (cherry picked from commit f7d106d)
🎉This issue was addressed in #4938, which has now been successfully released as Handy links: |
I'm sorry if this has been reported before, spent some time searching through the issues but couldn't find it.
Right now, if I type ctrl-NUM, it seems like it's not being picked up by the terminal app properly. Specifically, I've been trying to get the ctrl-6 vim behaviour to work, but I can't figure out if it's possible.
Thanks!
The text was updated successfully, but these errors were encountered: