Skip to content

Settings UI: dismissing a ComboBox dropdown by clicking another control also activates that control (light-dismiss click passes through) #20402

Description

@steven-pribilinskiy

Description

In the Settings UI, when a ComboBox dropdown is open and the user clicks outside it to dismiss, the click is not consumed by the light-dismiss — it also lands on whatever control is underneath. Example from the profile Appearance page: with the color scheme dropdown open, clicking the expander's chevron both closes the dropdown and toggles the expander.

Flyout-based popovers behave correctly by comparison: the "More colors…" flyout on the same page consumes the outside click when light-dismissing.

This affects every ComboBox in the Settings UI (it likely stems from light-dismiss handling in the XAML island hosting the settings). LightDismissOverlayMode="On" per-ComboBox would consume the click, but dims the window and would make individual combos inconsistent with the rest of the app, so it doesn't look like the right fix.

Steps to reproduce

  1. Open Settings → any profile → Appearance.
  2. Open the "Color scheme" ComboBox dropdown.
  3. Click the expander chevron (or any other control) outside the open dropdown.

Expected: the dropdown closes; the click is consumed (matching Flyout light-dismiss behavior).
Actual: the dropdown closes and the underlying control activates (the expander toggles).

Observed on Windows Terminal stable and on a local main build. Split out of PR #20390 validation; not introduced by that PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs-Tag-FixDoesn't match tag requirementsNeeds-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions