Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session restoration happens even after I explicitly close all tabs #16741

Closed
DHowett opened this issue Feb 20, 2024 · 0 comments · Fixed by #16598
Closed

Session restoration happens even after I explicitly close all tabs #16741

DHowett opened this issue Feb 20, 2024 · 0 comments · Fixed by #16598
Assignees
@DHowett @lhecker
Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@DHowett
Copy link
Member

DHowett commented Feb 20, 2024

Windows Terminal version

Preview 1.20

Windows build number

No response

Other Software

No response

Steps to reproduce

  1. Open 5 tabs
  2. Close them one by one
  3. Win+R, wt

Expected Behavior

No response

Actual Behavior

It opens 5 tabs.
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 20, 2024
@DHowett DHowett added this to the Terminal v1.21 milestone Feb 20, 2024
@DHowett DHowett added the Priority-1 A description (P1) label Feb 20, 2024
@lhecker lhecker mentioned this issue Feb 21, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Feb 21, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Feb 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 29, 2024
@lhecker
Implement buffer restore (#16598)
c4c5206 
This changeset allows Windows Terminal to dump its buffer contents as
UTF-16LE VT text onto disk and restore it later. This functionality is
enabled whenever `persistedWindowLayout` is being used.

Closes #961
Closes #16741

## Validation Steps Performed
* Open multiple windows with multiple tabs and restart the app
  Everything's restored ✅
* Reopen a tab with output from `RenderingTests.exe`
  Everything's restored ✅
* Closing tabs and windows with Ctrl+W deletes their buffer dumps ✅
* Closing tabs doesn't create buffer dumps ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

@lhecker lhecker

Labels
In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Implement buffer restore microsoft/terminal
3 participants
@DHowett @lhecker @carlos-zamora