Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental "marks" settings are documented as global, but are per-profile #13583

Closed
TBBle opened this issue Jul 23, 2022 · 2 comments · Fixed by #13655
Closed

Experimental "marks" settings are documented as global, but are per-profile #13583

TBBle opened this issue Jul 23, 2022 · 2 comments · Fixed by #13655
Labels
Area-Schema Things that have to do with the json schema. Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.16

Comments

@TBBle
Copy link

TBBle commented Jul 23, 2022 •
edited
Loading

#13414 added experimental.autoMarkPrompts and experimental.showMarksOnScrollbar to the Globals section of doc/cascadia/profiles.schema.json (and they were also described as such in the relevant release notes), but these settings are per-profile (as you'd expect such settings to be, and as documented in #11000).

Confirmed both because that's where they actually work in the profile, and by their presence in the MTSM_PROFILE_SETTINGS macro.

At least in VS Code's case, there's also an issue that even with the $schema pointing at the correct JSON schema, validation does not like the new scrollToMark action, or in fact any of the new marks, but I suspect that is more of a VSCode JSON editor issue, since it's also rejecting intenseTextStyle as a profile setting. >_<
@TBBle TBBle added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Jul 23, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 23, 2022
@TBBle
Copy link
Author

TBBle commented Jul 23, 2022

Also, the current JSON schema in main is probably invalid JSON, but that doesn't seem worth a separate bug report since fixing this will have to touch that file anyway.

@zadjii-msft
Copy link
Member

Huh. Thanks for the heads up!

@zadjii-msft zadjii-msft added Area-Schema Things that have to do with the json schema. Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. labels Jul 26, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 26, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Jul 26, 2022
@carlos-zamora carlos-zamora mentioned this issue Aug 2, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 2, 2022
carlos-zamora added a commit that referenced this issue Aug 2, 2022
@carlos-zamora
[Schema] Move scroll mark settings from global to profile settings (#…
61d84a7 
…13655)

Updates the schema such that the scroll mark settings are defined as profile settings instead of global settings (because they're actually profile settings).

Separately (but still relevant), I've also updated the release notes.

Closes #13583
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.16
Development

Successfully merging a pull request may close this issue.

[Schema] Move scroll mark settings from global to profile settings microsoft/terminal
2 participants
@TBBle @zadjii-msft