-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and use snmalloc, mimalloc for allocation performance #10976
Comments
https://github.com/microsoft/mimalloc is more general purpose while snmalloc is for message-passing specifically. Use both as needed in places where allocations need to occur and can't simply be removed. |
So it looks all we need to do here is add it to the build steps. contour-terminal/contour#341 shows how it's done for cmake. MSVC makes it bit more difficult as you need to ensure build steps are done properly in order and while I'd like to take a stab at this, I'm concerned about messing the build up trying to add this. I'd start with mimalloc first in this case and follow all of it's recommendations for flags for C++:
Also see https://github.com/microsoft/mimalloc#override-on-windows for Windows specific optimizing. |
@skyline75489 Are you comfortable with messing with the build steps to see how much of a boost we get in Process Explorer? |
Chester is unfortunately currently already preoccupied. |
Description of the new feature/enhancement
Github randomly revealed a project from Microsoft that upon investigation seems like it would be pretty useful here to possibly boost performance for allocations. https://github.com/microsoft/snmalloc
Proposed technical implementation details (optional)
The text was updated successfully, but these errors were encountered: