Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D&D on the '+' button: Dragging a drive letter (c:\) behaves weird #10723

Closed
Tracked by #10725
zadjii-msft opened this issue Jul 20, 2021 · 1 comment · Fixed by #10842
Closed
Tracked by #10725

D&D on the '+' button: Dragging a drive letter (c:\) behaves weird #10723

zadjii-msft opened this issue Jul 20, 2021 · 1 comment · Fixed by #10842
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@zadjii-msft
Copy link
Member

Follow up to #10160.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 20, 2021
@zadjii-msft zadjii-msft mentioned this issue Jul 20, 2021
Open
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Jul 20, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 20, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 20, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 22, 2021
@ianjoneill ianjoneill mentioned this issue Aug 1, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 1, 2021
@ghost ghost closed this as completed in #10842 Aug 3, 2021
@ghost ghost removed the In-PR This issue has a related PR label Aug 3, 2021
ghost pushed a commit that referenced this issue Aug 3, 2021
@ianjoneill
Fix drag and drop on '+' button for drive letters (#10842)
cccaab8 
Fixes dragging and dropping drive letters onto the '+' button.

Manually tested - dragging and dropping the `C:\` drive onto the '+' button works when creating a new tab, splitting or creating a new window. Dragging and dropping a regular directory still works.

Closes #10723
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 3, 2021
@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10842, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Fix drag and drop on '+' button for drive letters ianjoneill/terminal
2 participants
@DHowett @zadjii-msft