Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funky scroll bars in 1.10's settings UI #10664

Closed
vefatica opened this issue Jul 14, 2021 · 5 comments · Fixed by #10716
Closed

Funky scroll bars in 1.10's settings UI #10664

vefatica opened this issue Jul 14, 2021 · 5 comments · Fixed by #10716
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.11

Comments

@vefatica
Copy link

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19042.1110 (2009, 20H2) WindowsTerminal: 1.10.1933.0

Other Software

No response

Steps to reproduce

Start Windows Terminal 1.10.1933.0 ... open the settings UI ... go to "Defaults" or any profile ... observe the scroll bar

Expected Behavior

Not what's pictured below

Actual Behavior

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 14, 2021
@DHowett
Copy link
Member

DHowett commented Jul 14, 2021

This seems familiar. @mimvdm Suspect that this might be related to the ScrollViewer? 😄

@zadjii-msft
Copy link
Member

(looks like Dustin typo'd - @mimvdb as an fyi)

This is easier to repro when you disable the auto-hiding scrollbars systemwide. You can still repro it without it though, if you navigate to the appearances page, then hover just to the left of the scrollbar and scroll the page. The other "hidden" scrollbar will reveal itself.

The easy fix would be to revert #10619, but maybe there's another easier way to fix that part of #10609.

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 19, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 19, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.11 milestone Jul 19, 2021
@zadjii-msft zadjii-msft added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Jul 19, 2021
@DHowett
Copy link
Member

DHowett commented Jul 19, 2021

Whoops. Thanks.

@mimvdb mimvdb mentioned this issue Jul 19, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 19, 2021
@ghost ghost closed this as completed in #10716 Jul 20, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 20, 2021
ghost pushed a commit that referenced this issue Jul 20, 2021
@mimvdb
Add background color to grid to prevent animation overflow (#10716)
0fefdac 
## Summary of the Pull Request
Add an explicit background color to part of the settings UI to prevent animation overflow. The previous solution (adding a ScrollViewer) caused problems.

## References
#10619 adds a ScrollViewer for one of the issues in #10609

## PR Checklist
* [x] Closes #10664
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Detailed Description of the Pull Request / Additional comments

## Validation Steps Performed
Visually confirmed the animation doesn't overflow, changed the theme and confirmed the colors are responsive. Confirmed the extra scrollbar is gone.
@zadjii-msft zadjii-msft mentioned this issue Jul 21, 2021
Closed
@DHowett DHowett mentioned this issue Jul 22, 2021
Closed
DHowett pushed a commit that referenced this issue Aug 25, 2021
@mimvdb @DHowett
Add background color to grid to prevent animation overflow (#10716)
36879c1 
## Summary of the Pull Request
Add an explicit background color to part of the settings UI to prevent animation overflow. The previous solution (adding a ScrollViewer) caused problems.

## References
#10619 adds a ScrollViewer for one of the issues in #10609

## PR Checklist
* [x] Closes #10664
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Detailed Description of the Pull Request / Additional comments

## Validation Steps Performed
Visually confirmed the animation doesn't overflow, changed the theme and confirmed the colors are responsive. Confirmed the extra scrollbar is gone.
@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10716, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 31, 2021

🎉This issue was addressed in #10716, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

@miniksa miniksa removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Sep 27, 2021
@zadjii-msft zadjii-msft mentioned this issue Jan 31, 2022
Closed
6 tasks
@ghost ghost mentioned this issue Apr 4, 2022
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.11
Development

Successfully merging a pull request may close this issue.

Add background color to grid to prevent animation overflow mimvdb/terminal
4 participants
@DHowett @miniksa @zadjii-msft @vefatica