Remove "feedback" from the dropdown, and replace with "Command Palette"

[zadjii-msft]

• we know for a fact that no one's filed any issues using the feedback button
• We know that the command palette is terribly undiscoverable
• the command palette is also a great entry to discover basically every other command we have

so let's yank feedback, and replace with the cmdpal.

In the future, the new tab dropdown will be defaulted to [allProfiles, separator, toggleCommandPalette()] (#1571), so someone can remove it if they want.

Notes: might need to manually toss focus to the cmdpal - let's be careful here

[KnapSac]

I'd like to give this a shot, am I correct that this would need to be changed:

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Lines 686 to 696 in 27582a9

	// Create the feedback button.
	auto feedbackFlyout = WUX::Controls::MenuFlyoutItem{};
	feedbackFlyout.Text(RS_(L"FeedbackMenuItem"));
	WUX::Controls::FontIcon feedbackIcon{};
	feedbackIcon.Glyph(L"\xE939");
	feedbackIcon.FontFamily(Media::FontFamily{ L"Segoe MDL2 Assets" });
	feedbackFlyout.Icon(feedbackIcon);
	feedbackFlyout.Click({ this, &TerminalPage::_FeedbackButtonOnClick });
	newTabFlyout.Items().Append(feedbackFlyout);

[zadjii-msft]

@KnapSac That's exactly the spot! I believe the team consensus was to use the "LightningBolt" icon, which is \xE945

[KnapSac]

I have a couple uni assignments to finish up, but I expect to have a PR ready by early next week.

In the settings UI, the "Actions" page has a keyboard icon. Wouldn't it make more sense to keep these 2 icons the same? Since the command palette provides access to those actions?

[zadjii-msft]

That's a good observation!

We're actually only temporarily using the keyboard icon for the actions page. I think in the long run, we're actually planning on moving that to the lightning bolt as well. Right now the actions page only really works for actions that are bound to the keyboard, hence the keyboard icon. We have plans to update that page in the future to support configuring all actions, including everything in the command palette. This ties into some other plans we have for having actions accessible from the keyboard, the command palette, the new tab dropdown, the context menu... basically a ton of places.

I'll also tag in @cinnamon-msft, who can override that decision if they like.

[Chips1234]

@zadjii-msft If we're going to get rid of the "feedback" menu item, should we then add a "feedback" link in the "About" window that needs to feedback hub or "Visit our GitHub repository" that leads here?

[ghost]

🎉This issue was addressed in #10297, which has now been successfully released as Windows Terminal Preview v1.10.1933.0.:tada:

Handy links:

• Release Notes
• Store Download