Disable automatic function calling, and show structured output #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsaamir
force-pushed
the
aamirj/disableAutoFunctionCalling
branch
from
c294446 to
5d27f5a
Compare
lilyydu
reviewed
Jun 2, 2025
corinagum
reviewed
Jun 3, 2025
corinagum
reviewed
Jun 4, 2025
corinagum
previously requested changes
Jun 4, 2025
There was a problem hiding this comment.
Thanks for the PR @heyitsaamir! I made a couple nit suggestions / asked a question, but looks good to me!
heyitsaamir
force-pushed
the
aamirj/disableAutoFunctionCalling
branch
from
67dc3b4 to
400e5cc
Compare
heyitsaamir
requested review from
ydogandjiev,
Jesperholmbergmsft and
dclaux
as code owners
Jesperholmbergmsft
previously approved these changes
Jun 10, 2025
aacebo
reviewed
Jun 12, 2025
aacebo
reviewed
Jun 12, 2025
aacebo
previously approved these changes
Jun 12, 2025
heyitsaamir
dismissed
corinagum’s stale review
Corina's OOF, and i've addressed her concerns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for the disabling of automatic function calling. With this, we enable users to be able to leverage ChatPrompt to do structured output. Added a test for that too.
skip-test-verification - We really should make an ai test that's as close as possible to the template. Right now it's very different. I'll do that in a different PR.
PR Dependency Tree
This tree was auto-generated by Charcoal