-
Notifications
You must be signed in to change notification settings - Fork 11
Add dialog samples #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add dialog samples #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
reviewed
Apr 24, 2025
corinagum
previously approved these changes
Apr 24, 2025
heyitsaamir
added a commit
to microsoft/teams-ai
that referenced
this pull request
Apr 25, 2025
- Adds some dialog docs (in conjunction with dialog samples microsoft/teams.ts#175) - Our mdbook build/serve step wasn't failing if links were broken. The error would be printed, but it wouldn't fail. rust-lang/mdBook#2277. I improved the script so that it watched for the `[ERROR]` string and failed if it saw it.
aacebo
reviewed
Apr 29, 2025
aacebo
reviewed
Apr 29, 2025
corinagum
reviewed
Apr 29, 2025
corinagum
previously approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a question, and I'm not sure if you meant to delete the commented out code @aacebo commented on or not.
lilyydu
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
appPackage
is automatically added. This is needed if we want to test the samples in Teams.Important
This PR currently points to
aamirj/fixFetchTaskTypes
which contains some fixes that were needed for this sample to work correctly.