Skip to content

Add dialog samples #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 30, 2025
Merged

Add dialog samples #175

merged 29 commits into from
Apr 30, 2025

Conversation

heyitsaamir
Copy link
Contributor

In this PR:

  1. We fix the samples generator so that appPackage is automatically added. This is needed if we want to test the samples in Teams.
  2. We add a dialog sample that's used in docs.

Important

This PR currently points to aamirj/fixFetchTaskTypes which contains some fixes that were needed for this sample to work correctly.

corinagum
corinagum previously approved these changes Apr 24, 2025
heyitsaamir added a commit to microsoft/teams-ai that referenced this pull request Apr 25, 2025
- Adds some dialog docs (in conjunction with dialog samples
microsoft/teams.ts#175)
- Our mdbook build/serve step wasn't failing if links were broken. The
error would be printed, but it wouldn't fail.
rust-lang/mdBook#2277. I improved the script so
that it watched for the `[ERROR]` string and failed if it saw it.
Base automatically changed from aamirj/fixFetchTaskTypes to main April 28, 2025 20:36
@aacebo aacebo dismissed corinagum’s stale review April 28, 2025 20:36

The base branch was changed.

corinagum
corinagum previously approved these changes Apr 29, 2025
Copy link
Collaborator

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a question, and I'm not sure if you meant to delete the commented out code @aacebo commented on or not.

@heyitsaamir heyitsaamir merged commit 1c9d1c5 into main Apr 30, 2025
5 checks passed
@heyitsaamir heyitsaamir deleted the aamirj/dialogSamples branch April 30, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants