-
Notifications
You must be signed in to change notification settings - Fork 259
[docs]: add regional config section to user authentication #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| To properly configure your regional bot, you will need to make a few updates. This example uses West Europe, but follow the equivalent for other regions. | ||
|
|
||
| 1. In `azurebot.bicep`, replace all `global` occurrences to `westeurope` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also only applies when the bot is being created.
We should call out that this is only if they use ATK. It would be also good to call the equivalent guidance if they configure it manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a remark that this is for ATK, by manual you mean adding the steps for Azure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, because if they don't have an azure bicep file, this doesn't apply
teams.md/src/components/include/in-depth-guides/user-authentication/typescript.incl.md
Show resolved
Hide resolved
teams.md/src/components/include/in-depth-guides/user-authentication/typescript.incl.md
Show resolved
Hide resolved
| app = App( | ||
| default_connection_name='graph', | ||
| api_client_settings=ApiClientSettings( | ||
| oauth_url=os.environ.get("OAUTH_URL") # Value would be "https://europe.token.botframework.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this at all right? It should be updates in the .env file or wherever they set their environment variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still good to showcase here so they know what the value should look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this actually makes it look like this is a required thing they need to provide in code. And it's not clear that it'll automatically use this config from the environment variable.
You could show the same thing but instead of here, show it in an .env file instead
added typescript and python as .NET implementation will be delayed with other refactorings