-
Notifications
You must be signed in to change notification settings - Fork 262
Description
Scenario
Please look at this code:
It restricts the means for authentication to using the configuration-based approach only in two ways:
a) it doesn't expose an equivalent to the CloudAdapter constructor that accepts a custom BotFrameworkAuthentication instance.
b) it hardcodes usage of ConfigurationServiceClientCredentialFactory.
This makes it impossible to use Teams.AI when the underlying bot framework configuration is using federated credentials, which is currently pending a configuration-based implementation (see microsoft/botbuilder-dotnet#6838).
Solution
One or both of the following:
- The bot framework implements the configuration-based approach for federated credentials (I've suggested an extension of this PR here).
- The Teams.AI library allows passing a custom
BotFrameworkAuthenticationinstance toTeamsAdapter.
Just the first approach will work as an immediate solution and may be the easier of the two, but the second approach seems like it should be supported in general to enable more flexibility around authentication.
Additional Context
Thanks in advance for considering!