Skip to content

Conversation

@polarG
Copy link
Contributor

@polarG polarG commented Oct 16, 2025

Description
Python3.10 pipeline failed.

Solution
From log, 'bc' cmd is missing. Since our image tags are simple, the solution is to remove 'bc' cmd directly.

@polarG polarG requested a review from a team as a code owner October 16, 2025 16:52
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.70%. Comparing base (d804dbb) to head (2628042).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files         102      102           
  Lines        7623     7623           
=======================================
  Hits         6533     6533           
  Misses       1090     1090           
Flag Coverage Δ
cpu-python3.10-unit-test 70.82% <ø> (ø)
cpu-python3.12-unit-test 70.82% <ø> (ø)
cpu-python3.7-unit-test 70.26% <ø> (ø)
cuda-unit-test 83.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG added bug Something isn't working CI/CD Continuous integration or deployment labels Oct 16, 2025
@polarG polarG requested a review from guoshzhao October 16, 2025 23:46
@guoshzhao guoshzhao self-assigned this Oct 17, 2025
@abuccts abuccts requested a review from Copilot October 22, 2025 02:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Python 3.10 CI/CD pipeline by removing the dependency on the bc command, which was missing in the Docker image. The solution replaces the shell-based version comparison with a native Python version check.

Key changes:

  • Replaced bc-based version comparison with Python's sys.version_info check
  • Simplified the conditional logic for determining when to install specific setuptools version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@polarG polarG enabled auto-merge (squash) October 22, 2025 03:03
@polarG polarG merged commit 86a940c into main Oct 22, 2025
105 of 247 checks passed
@polarG polarG deleted the hongtaozhang/fix-py310-pipeline branch October 22, 2025 03:53
@guoshzhao guoshzhao mentioned this pull request Nov 10, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD Continuous integration or deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants