Skip to content

Conversation

@polarG
Copy link
Contributor

@polarG polarG commented Sep 22, 2025

To improve benchmark debugging, the following debug methods were added:

pytorch profiler in model benchmark

  • SB_ENABLE_PYTORCH_PROFILER: switch to enable/disable
  • SB_TORCH_PROFILER_TRACE_DIR: log path
    These 2 runtime variables need to be configured in SB config file.

nsys in SB runner

  • SB_ENABLE_NSYS: switch to enable/disable
  • SB_NSYS_TRACE_DIR: log path
    These 2 runtime variables need to be configured in runner's ENV

@polarG polarG requested a review from a team as a code owner September 22, 2025 16:57
@polarG polarG added the enhancement New feature or request label Sep 22, 2025
@polarG polarG requested review from guoshzhao and shcho September 22, 2025 16:58
@guoshzhao guoshzhao changed the title Enhancement: Add debug trace support Enhancement: Add nsys debug trace support Oct 2, 2025
@guoshzhao guoshzhao changed the title Enhancement: Add nsys debug trace support Enhancement: Add nsys and pytorch profiler debug trace support Oct 2, 2025
@guoshzhao guoshzhao mentioned this pull request Oct 2, 2025
30 tasks
@guoshzhao guoshzhao self-assigned this Oct 2, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 42.55319% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.70%. Comparing base (b986424) to head (1014f6f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rbench/benchmarks/model_benchmarks/pytorch_base.py 18.75% 26 Missing ⚠️
superbench/runner/runner.py 93.33% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (42.55%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   85.97%   85.70%   -0.28%     
==========================================
  Files         102      102              
  Lines        7579     7623      +44     
==========================================
+ Hits         6516     6533      +17     
- Misses       1063     1090      +27     
Flag Coverage Δ
cpu-python3.10-unit-test 70.82% <36.17%> (-0.23%) ⬇️
cpu-python3.12-unit-test 70.82% <36.17%> (-0.23%) ⬇️
cpu-python3.7-unit-test 70.26% <36.17%> (-0.23%) ⬇️
cuda-unit-test 83.59% <40.42%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG enabled auto-merge (squash) October 8, 2025 23:10
@polarG polarG merged commit d804dbb into main Oct 8, 2025
25 of 27 checks passed
@polarG polarG deleted the hongtaozhang/add-trace-support branch October 8, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants