-
Notifications
You must be signed in to change notification settings - Fork 80
Benchmark: Model benchmark - add option to exclude data copy time in model benchmarks #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (52.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
==========================================
- Coverage 86.08% 85.97% -0.12%
==========================================
Files 102 102
Lines 7553 7578 +25
==========================================
+ Hits 6502 6515 +13
- Misses 1051 1063 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new --no_copy option to model benchmarks that allows excluding data copy time from benchmark measurements. When enabled, the timing measurement starts after the GPU data copy operation is completed rather than before it.
- Added a new command-line argument
--no_copyto exclude data copy time from benchmarks - Modified timing logic in all model benchmark implementations to optionally start timing after GPU memory transfers
- Updated test documentation to reflect the new option
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| model_base.py | Adds the new --no_copy command-line argument definition |
| pytorch_*.py (6 files) | Implements the timing logic to start measurement after GPU data copy when --no_copy is enabled |
| test_model_base.py | Updates test documentation to include the new --no_copy option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
add option to exclude data copy time in model benchmarks.
Major Revision