Skip to content

Conversation

@yukirora
Copy link
Contributor

@yukirora yukirora commented Sep 5, 2025

Description
add --set_ib_devices option to auto-select IB device by MPI local rank

Major Revision

  • Add a new CLI flag --set_ib_devices to automatically select irregular IB devices based on the MPI local rank.
  • When enabled, the benchmark queries available IB devices via network.get_ib_devices() and selects the device corresponding to OMPI_COMM_WORLD_LOCAL_RANK.
  • Fall back to existing --ib_dev behavior when the flag is not provided.

Minor Revision

  • Add an env in network.get_ib_devices() to allow user to set the device name

@yukirora yukirora requested a review from a team as a code owner September 5, 2025 07:48
@yukirora yukirora changed the title Benchmarks: ib validation - add --set_ib_devices option to auto-select IB device by MPI local rank Benchmarks: micro benchmarks - add --set_ib_devices option to auto-select IB device by MPI local rank in ib validation Sep 5, 2025
@yukirora yukirora added the benchmarks SuperBench Benchmarks label Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.69%. Comparing base (25db111) to head (aa7f39e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...arks/micro_benchmarks/ib_validation_performance.py 70.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (76.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   85.71%   85.69%   -0.02%     
==========================================
  Files         102      102              
  Lines        7678     7691      +13     
==========================================
+ Hits         6581     6591      +10     
- Misses       1097     1100       +3     
Flag Coverage Δ
cpu-python3.10-unit-test 70.95% <76.92%> (+0.01%) ⬆️
cpu-python3.12-unit-test 70.95% <76.92%> (+0.01%) ⬆️
cpu-python3.7-unit-test 70.40% <76.92%> (+0.01%) ⬆️
cuda-unit-test 83.60% <76.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yukirora yukirora enabled auto-merge (squash) September 19, 2025 02:04
@guoshzhao guoshzhao added the micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks label Sep 19, 2025
@yukirora yukirora disabled auto-merge September 22, 2025 09:13
@guoshzhao guoshzhao mentioned this pull request Oct 2, 2025
30 tasks
@yukirora yukirora merged commit c65ae56 into main Nov 17, 2025
25 of 27 checks passed
@yukirora yukirora deleted the yutji/add-ibdevices branch November 17, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants