Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor - Collect realtime GPU power when benchmarking. #507

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Monitor - Collect realtime GPU power when benchmarking. #507

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15ff0a5
collect realtime GPU power when benchmarking.
guoshzhao Apr 7, 2023
b4e98fb
util function
guoshzhao Apr 7, 2023
30dd22f
fix parse issue.
guoshzhao Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions superbench/monitor/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ def __sample_gpu_metrics(self, record):
for i in range(device_count):
record.gpu_usage.append(dm.device_manager.get_device_utilization(i))
record.gpu_temperature.append(dm.device_manager.get_device_temperature(i))
record.gpu_power.append(dm.device_manager.get_device_power(i))
record.gpu_power_limit.append(dm.device_manager.get_device_power_limit(i))
mem_used, mem_total = dm.device_manager.get_device_memory(i)
record.gpu_mem_used.append(mem_used)
Expand Down
16 changes: 16 additions & 0 deletions superbench/monitor/record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class MonitorRecord:
"""Record class to save all monitoring data."""
reduce_ops = {
'gpu_temperature': ReduceType.MAX,
'gpu_power': ReduceType.MAX,
'gpu_power_limit': ReduceType.MIN,
'gpu_corrected_ecc': ReduceType.LAST,
'gpu_uncorrected_ecc': ReduceType.LAST,
Expand All @@ -28,6 +29,7 @@ def __init__(self):
self.__mem_total = None
self.__gpu_usage = list()
self.__gpu_temperature = list()
self.__gpu_power = list()
self.__gpu_power_limit = list()
self.__gpu_mem_used = list()
self.__gpu_mem_total = list()
Expand Down Expand Up @@ -112,6 +114,20 @@ def gpu_temperature(self, gpu_temperature):
"""
self.__gpu_temperature = gpu_temperature

@property
def gpu_power(self):
"""Decoration function to access __gpu_power."""
return self.__gpu_power

@gpu_power.setter
def gpu_power(self, gpu_power):
"""Set the gpu realtime power, unit: Watt.

Args:
gpu_power(list): list of gpu realtime power.
"""
self.__gpu_power = gpu_power

@property
def gpu_power_limit(self):
"""Decoration function to access __gpu_power_limit."""
Expand Down
4 changes: 2 additions & 2 deletions tests/monitor/test_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ def test_monitor(self):

monitor._Monitor__sample_gpu_metrics(record)
gpu_list_metrics = [
record.gpu_usage, record.gpu_temperature, record.gpu_power_limit, record.gpu_mem_used, record.gpu_mem_total,
record.gpu_corrected_ecc, record.gpu_uncorrected_ecc
record.gpu_usage, record.gpu_temperature, record.gpu_power, record.gpu_power_limit, record.gpu_mem_used,
record.gpu_mem_total, record.gpu_corrected_ecc, record.gpu_uncorrected_ecc
]
for metric in gpu_list_metrics:
assert (metric)
Expand Down
9 changes: 9 additions & 0 deletions tests/monitor/test_monitor_record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ def test_monitor_record():
mr.mem_total = 1024
mr.gpu_usage = [90, 80, 86, 72, 79, 81, 94, 85]
mr.gpu_temperature = [62, 75, 69, 63, 72, 77, 80, 71]
mr.gpu_power = [257, 290, 280, 262, 291, 284, 281, 273]
mr.gpu_power_limit = [400, 400, 400, 350, 400, 400, 400, 400]
mr.gpu_mem_used = [2550, 2680, 2543, 2588, 2612, 2603, 2515, 2593]
mr.gpu_mem_total = [16777216, 16777216, 16777216, 16777216, 16777216, 16777216, 16777216, 16777216]
Expand Down Expand Up @@ -59,6 +60,14 @@ def test_monitor_record():
'gpu_temperature:5': 77,
'gpu_temperature:6': 80,
'gpu_temperature:7': 71,
'gpu_power:0': 257,
'gpu_power:1': 290,
'gpu_power:2': 280,
'gpu_power:3': 262,
'gpu_power:4': 291,
'gpu_power:5': 284,
'gpu_power:6': 281,
'gpu_power:7': 273,
'gpu_power_limit:0': 400,
'gpu_power_limit:1': 400,
'gpu_power_limit:2': 400,
Expand Down