You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 14, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 14, 2026. It is now read-only.
OnConnectionChanged parameter type differs from ADS version #88
Here we defined the parameter for onConnectionChanged to have an "ownerUri" property, but the corresponding type in ADS of ChangedConnectionInfo has connectionUri.
Since extensions are typically only going to be using the azdata typings this shouldn't be the case, and could easily lead to providers sending the wrong values.
Changes here should be carefully verified though, one such attempt already broke some key functionality - see microsoft/azuredatastudio#23565 for more details
Here we defined the parameter for onConnectionChanged to have an "ownerUri" property, but the corresponding type in ADS of ChangedConnectionInfo has connectionUri.
Since extensions are typically only going to be using the azdata typings this shouldn't be the case, and could easily lead to providers sending the wrong values.