Skip to content
This repository was archived by the owner on Sep 14, 2026. It is now read-only.
This repository was archived by the owner on Sep 14, 2026. It is now read-only.

OnConnectionChanged parameter type differs from ADS version #88

Description

Here we defined the parameter for onConnectionChanged to have an "ownerUri" property, but the corresponding type in ADS of ChangedConnectionInfo has connectionUri.

Since extensions are typically only going to be using the azdata typings this shouldn't be the case, and could easily lead to providers sending the wrong values.

Activity

  1. Charles-Gagnon commented on Jul 6, 2023

    @Charles-Gagnon
    ContributorAuthor

    Changes here should be carefully verified though, one such attempt already broke some key functionality - see microsoft/azuredatastudio#23565 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions